chore: upgrade and prune dependencies#439
Conversation
📝 WalkthroughWalkthroughThis PR removes conditional build tags from the Makefile, migrates UUID imports from the versioned module to the non-versioned module, improves error handling in session checks, and updates the Go dependency graph across direct and transitive dependencies. ChangesBuild system, imports, and dependency updates
🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@cmd/cloudx/proxy/helpers.go`:
- Line 379: Replace the bare return of
errors.WithStack(herodot.ErrInternalServerError()) on request-creation failure
with the same chained form used for JSON-decode failures: call
errors.WithReasonf("request creation failed: %s", someContext).WithWrap(err) (or
similar descriptive reason) instead of WithStack, ensuring you pass the original
error variable (err) into WithWrap so the error retains diagnostic context and
use herodot.ErrInternalServerError() as the base error like the other cases.
In `@Makefile`:
- Line 16: The Makefile build/test targets were changed to remove the build
tags, causing a mismatch with .docker/Dockerfile-build (which still uses -tags
sqlite,json1) and CONTRIBUTING.md (which references go test -tags sqlite ./...),
so restore tag consistency: update the Makefile targets that run go build and go
test (the lines invoking "go build -o .bin/cli github.com/ory/cli" and the other
build/test targets around lines referenced) to include the same -tags
sqlite,json1 flags, or alternatively update .docker/Dockerfile-build and
CONTRIBUTING.md in this PR to remove sqlite/json1 references — pick one approach
and apply it consistently to all build/test entrypoints so the build/test tag
matrix matches across Makefile, Dockerfile-build, and docs.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 4b0fbccd-fbc8-4dd4-882b-74b80dbc1113
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (4)
Makefilecmd/cloudx/oauth2/client_test.gocmd/cloudx/proxy/helpers.gogo.mod
Summary by CodeRabbit
Bug Fixes
Chores